Re: [tor-bugs] #3571 [Pluggable transport]: obfsproxy: Please review portability fixes

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3571: obfsproxy: Please review portability fixes
---------------------------------+------------------------------------------
 Reporter:  zwol                 |          Owner:  asn         
     Type:  enhancement          |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:              
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by asn):

 I'm not one to review portability fixes; my automake/portability skills
 are non-existent, so I just read the commits that I have some experience
 with.

 I checked out "Avoid embedding struct sockaddr in protocol_params_t."
 which is a thing I wanted to do for a while and it seems okay. When my
 function documentation branch (#3301) gets merged, we should mention that
 `addr_out` should be freed on `resolve_address_port()`'s documentation.

 I checked out "Clean up the logging API." which also seems okay in my
 book, apart from the fact that the function documentation is now outdated,
 left with the "-1/1" return convention.

 I also think that "Move obfs2_crypt.[ch] to top level and rename them
 crypt.[ch]." is a good idea (at least till a better idea comes up).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3571#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs