[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6298 [Tor Relay]: Test 'addr/basic' failure in tor master
#6298: Test 'addr/basic' failure in tor master
-----------------------+----------------------------------------------------
Reporter: andrea | Owner:
Type: defect | Status: new
Priority: minor | Milestone: Tor: unspecified
Component: Tor Relay | Version: Tor: unspecified
Keywords: | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Comment(by nickm):
Agreed that unit tests shouldn't hit the network, and should work even on
this crappy hotel internet.
One option here is to take the part of that test that hits the network and
make it disabled-by-default. I added a feature to the upstream tinytest
library last week that lets you mark some tests as not on-by-default, and
then turn them on by saying @network_dependent or @takes_too_long or
whatever. If that seems like a good choice, we can copy in the latest
tinytest, take all the tests that fail in the hotel, or when you turn your
laptop's wireless off, and mark them as disabled, and add an @alias to
turn them back on.
Mocking is also maybe a good choice, though we haven't done it yet. Are
there any good C mocking libraries/tools/systems/methodologies we should
be looking at?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6298#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs