[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6341 [Tor Relay]: connection_or_flush_from_first_active_circuit() wants refactoring (was: "if (circ != conn->active_circuits)" in connection_or_flush_from_first_active_circuit() is wrong?)
#6341: connection_or_flush_from_first_active_circuit() wants refactoring
-----------------------+----------------------------------------------------
Reporter: arma | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: Tor Relay | Version:
Keywords: | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Comment(by arma):
Apparently no code in that path can change conn->active_circuits, so
checking whether it's changed makes no sense. That's what this is about.
Our friendly bug reporter also points out that circ is
conn->active_circuits in the case of !ewma_enabled, but it's based on
conn->active_circuit_pqueue in the case of ewma_enabled. Sure seems like
some of this code didn't get cleaned up when we added the ewma patch.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6341#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs