[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6356 [Stem]: LOADCONF wrapper method for Stem
#6356: LOADCONF wrapper method for Stem
----------------------------+-----------------------------------------------
Reporter: neena | Owner: neena
Type: task | Status: closed
Priority: normal | Milestone:
Component: Stem | Version:
Resolution: implemented | Keywords:
Parent: | Points:
Actualpoints: |
----------------------------+-----------------------------------------------
Changes (by atagar):
* status: needs_review => closed
* resolution: => implemented
Comment:
Changes pushed, thanks!
Minor thing, but when you have a long list of things like...
> +__all__ = [
> + "descriptor",
> + "response",
> + "util",
> + "connection",
> + "control",
> + "prereq",
> + "process",
> + "socket",
> + "version"
> +]
... please include a comma on the last element. This makes reordering the
elements a little less error prone.
> [LOADCONF was added in Tor 0.2.1.1-alpha.]
When a feature has a version requirement please add it to
'stem.version.Requirement' and add a version requirement for the test.
Here's the revisions that I made to your changes...
https://gitweb.torproject.org/stem.git/commitdiff/ab553f54e70ea21d8bd117cf912e1b208417e5d5
Cheers! -Damian
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6356#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs