[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6304 [Tor Client]: CircuitBuildTimeout default value does not match man page

#6304: CircuitBuildTimeout default value does not match man page
------------------------+---------------------------------------------------
 Reporter:  dcf         |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  major       |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 NAK.  I believe that "0" is supposed to mean "use the default".  See the
 logic in circuit_build_times_get_initial_timeout().

 That said, the logic is screwy, and it looks like should change the outer
 "else" case of that function so that if !LearnCircuitBuildTimeout and
 !CircuitBuildTimeout, we fall back to circuit_build_times_initial_timeout.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6304#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs