Re: [tor-bugs] #6234 [Stem]: stem.socket.ControlSocket.is_alive() should check if socket is open explicitly

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#6234: stem.socket.ControlSocket.is_alive() should check if socket is open
explicitly
----------------------------+-----------------------------------------------
    Reporter:  gsathya      |       Owner:  atagar
        Type:  defect       |      Status:  closed
    Priority:  normal       |   Milestone:        
   Component:  Stem         |     Version:        
  Resolution:  implemented  |    Keywords:        
      Parent:               |      Points:        
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by atagar):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 >> Slightly weird idea, but instead of adding a quit() method what about
 adding a
 >> best-effort msg("QUIT") call to our close() method instead?
 >
 > I like it. Done.

 Most of my comments were no longer relevant if we went this route (in
 which case we simply make a best-effort QUIT attempt). Merged a simple
 change that does this...

 https://gitweb.torproject.org/stem.git/commitdiff/e2528b85f6b0bf1fb82c42599e71d1c925fcd6ae

 Feel free to reopen if there's something more that you think that we
 should do.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6234#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs