[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8978 [Tor]: Write server-side pluggable transport options to extra-info descriptor

#8978: Write server-side pluggable transport options to extra-info descriptor
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  task           |         Status:  needs_revision    
 Priority:  normal         |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor            |        Version:                    
 Keywords:  tor-bridge pt  |         Parent:                    
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 This part looks okay, but it totally needs unit tests for the new format.
 (And the existing unit tests for parse_smethod_line() should really be
 checking the output for correctness too.)

 (As a first approximation, each new or changed line of code in 0.2.5
 should have test coverage.  I'm not going to start actually trying to
 reach "100% of new lines" till after #8949 is merged, but we should try to
 close in on it, and not leave code untested when we could just as easily
 write the tests.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8978#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs