[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8292 [Firefox Patch Issues]: Alter behavior of getFirstPartyURI and consumers
#8292: Alter behavior of getFirstPartyURI and consumers
----------------------------------------------+-----------------------------
Reporter: mikeperry | Owner: mikeperry
Type: enhancement | Status: needs_revision
Priority: major | Milestone:
Component: Firefox Patch Issues | Version:
Keywords: tbb-linkability, MikePerry201307 | Parent:
Points: | Actualpoints:
----------------------------------------------+-----------------------------
Comment(by mcs):
Replying to [comment:10 mikeperry]:
> There is an issue with this patch. It looks like you missed a brace pair
around an NS_ADDREF() ThirdPartyUtil::GetFirstPartyURI(). Did/Can you test
this in a debug build for a while to check that there's no other potential
issues like that? If you need some tips hacking gitian to do this, I can
give more detailed instructions, but it should be fairly easy to change
the 'versions' file to specify a tor-browser.git branch that you
create+commit to, to add this patch and to edit the .mozconfig.
Thanks for your review. We did test quite a bit with a debug build (but
we built it outside of the gitian build method; I guess we should create a
remote tor-browser.git branch on torproject.org to make things simpler).
You are correct about the missing braces -- sorry! I don't think the
failure path is taken often so the missing braces had no bad effect during
our testing. Did you see a failed assert or other log message when
running the patch in a debug build?
> Also, maybe we want to try to solve #9336 as part of this? Perhaps the
improved logging here will help quickly diagnose that issue?
We will take a look at #9336 early next week in conjunction with polishing
this fix.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8292#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs