[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6320 [Atlas]: Implement fingerprint hash based search (bridge support)

#6320: Implement fingerprint hash based search (bridge support)
-----------------------------+--------------------------
     Reporter:  hellais      |      Owner:  phw
         Type:  enhancement  |     Status:  needs_review
     Priority:  major        |  Milestone:
    Component:  Atlas        |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------
Changes (by phw):

 * status:  assigned => needs_review


Comment:

 > phw, I have attached four patches necessary to make Atlas work with Tor
 bridges. If you prefer, I can push a tree to GitHub.

 Great work, thanks a lot!  Here's some feedback:

  * In the file "templates/details/bridge.html", there are several
 occurrences of the string "relay" which should be replaced with "bridge".
  * In the file "templates/details/error.html", we could now say "No Tor
 relays '''or bridges''' matched your query :(".
  * It might be useful to have a tooltip over the "OR Addresses" field on
 the "details" page which says that this is just a fake address and the
 bridge's real address is not revealed.  Otherwise, we might get some
 confused users.
  * On the search result page, it would be great if we could distinguish
 relays from bridges.  Perhaps by having another columns which says either
 "relay" or "bridge"?
  * `if (fp.match(/[a-f0-9]{40}/i) != null)` -- maybe we should match for
 upper case characters too?
  * FYI, https://globe.torproject.org also has bridge search and you might
 find its UI/implementation useful.

 Apart from the above, I'm not very familiar with Atlas' code base but
 maybe we can get hellais or karsten to have a look at the patch?  I will
 use your patch over the next couple of days and get back to you if I
 stumble across something else.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6320#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs