[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16666 [Tor]: ed25519-donna doesn't build on arm without warnings with the stack protector

#16666: ed25519-donna doesn't build on arm without warnings with the stack
protector
-------------------------+----------------------------------
     Reporter:  yawning  |      Owner:  yawning
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:  Tor: 0.2.7.2-alpha
   Resolution:           |   Keywords:  tor-core, tor-crypto
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+----------------------------------
Changes (by yawning):

 * status:  new => needs_review


Comment:

 https://github.com/Yawning/tor/compare/bug16666

 Yes, this should be fine even if GCC chooses to generate NEON code (and if
 it's not fine, that would be a GCC bug).  Yes, this will need changes if
 someone adds NEON code that requires alignment (but the changes required
 are trivial, and the performance penalty for non-aligned access isn't
 massive).

 Marking as needs-review, though it's laughably trivial.  If this is merged
 and fixes the issue, then d8352646900c6316af8e2967742ce6a438b04221
 probably can be reverted to keep our ed25519-donna code closer to upstream
 as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16666#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs