[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16429 [Tor Browser]: Isolate mediasource and blob URLs in all contexts

#16429: Isolate mediasource and blob URLs in all contexts
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  tbb-team
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  ff38-esr, tbb-linkability,
  Browser                |  TorBrowserTeam201507R, tbb-5.0a4
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:12 mcs]:
 > Kathy and I reviewed all of these changes and they look OK to us.  Just
 a few comments:
 > * Are there cases where the isolation key will be "--ISOLATION-FAILED-"
 when it would be better to just fail?  For example, we could fail the
 creation of a blob URL if we cannot get an isolation key.
 > * A nit: replace "isolationKey" with "aIsolationKey" in the
 nsHostObjectProtocolHandler::AddDataEntry() parameter list.
 > * The messageSent variable is not really used inside
 dom/base/test/bug15703_page_retrieve.html; you could just remove it.

 Thanks for the review and these helpful suggestions. I've made changes to
 address each of them. Here's the new branch:

 https://github.com/arthuredelstein/tor-browser/commits/16429+11

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16429#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs