[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18571 [Core Tor/Tor]: prop224: Encode/Decode descriptor implementation
#18571: prop224: Encode/Decode descriptor implementation
-----------------------------+------------------------------------
Reporter: dgoulet | Owner: special
Type: enhancement | Status: assigned
Priority: High | Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, prop224 | Actual Points:
Parent ID: #17238 | Points: 6
Reviewer: | Sponsor: SponsorR-must
-----------------------------+------------------------------------
Comment (by asn):
OK, David addressed my comments and added some more code.
You can find another review here:
https://gitlab.com/asn/tor/merge_requests/1/diffs#note_12822678
I did '''not''' really review the decoding commits because it said ''WIP''
and it has tons of XXX all around. So I thought of giving it some more
time to mature.
[https://gitweb.torproject.org/user/asn/tor.git/commit/?h=ticket18571_029_04_test&id=b81135e9ebcfd327099199c208185bca056fa617
I also started writing unit tests] for the `build_plaintext_padding()`
function in my `ticket18571_029_04_test` branch. I think the function is
actually broken as it is right now. Check out the test failures.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18571#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs