[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18529 [Core Tor/Tor]: Fix duplicate check for "only allow internal addresses if we are on a network with nonstandard authorities"
#18529: Fix duplicate check for "only allow internal addresses if we are on a
network with nonstandard authorities"
-------------------------------------------------+-------------------------
Reporter: nickm | Owner:
Type: defect | Status:
Priority: Low | needs_revision
Component: Core Tor/Tor | Milestone: Tor:
Severity: Trivial | 0.2.9.x-final
Keywords: easy, refactor, 029-nickm-says-yes, | Version: Tor:
review-group-3 | 0.2.8.1-alpha
Parent ID: | Resolution:
Reviewer: isis | Actual Points:
| Points: 1
| Sponsor:
-------------------------------------------------+-------------------------
Comment (by ericho):
Hi,
I updated the patch regarding this bug, but I only attend one code review
suggestion.
https://gist.github.com/ericho/992b6ffed459eb06f0bc932f68a48761
* The function is now named {{{ is_default_dir_authorities() }}}, what I
understand (I don't know much about how tor works) is that the idea is to
know whether the directory authorities was set or not.
* The function definition was moved to config.h and declared as inline.
* I'm not sure about {{{ tor_addr_is_internal }}} function, in the code in
the bug description this functions doesn't look repeated to me (unless I
confuse something), one call is looking a for a true value and the other
for false.
I hope this patch works, however I'll happy to send another one if
required.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18529#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs