[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19561 [Core Tor/Tor]: Misleading prop250 log messages
#19561: Misleading prop250 log messages
--------------------------+------------------------------------
Reporter: asn | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-sr | Actual Points:
Parent ID: | Points: 0.3
Reviewer: | Sponsor: SponsorR-must
--------------------------+------------------------------------
Changes (by dgoulet):
* cc: dgoulet (removed)
* keywords: tor-prop250 => tor-sr
Comment:
I would be fine with this extra hex encoded identity digest in the commit
because we use it quite often for logging and vote/state creation. We set
it only once at the commit creation in `commit_new()`. Easy addition
because we don't need to free it and it's immutable once the commit object
has been created.
`sr_commit_get_rsa_fpr()` returns the const pointer and we win. I see that
as a simple change that we should do now instead of once dirauth uses SR
with 029 stable. We can deploy it in our test net also prior to
deployment.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19561#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs