[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19624 [Metrics/ExoneraTor]: Exonerator should comply to Metrics Java style guide
#19624: Exonerator should comply to Metrics Java style guide
--------------------------------+--------------------------------
Reporter: iwakeh | Owner: karsten
Type: task | Status: needs_revision
Priority: Medium | Milestone:
Component: Metrics/ExoneraTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #19611 | Points:
Reviewer: | Sponsor:
--------------------------------+--------------------------------
Comment (by karsten):
Replying to [comment:4 iwakeh]:
> The changes look fine and can be merged.
Great, thanks for looking! Merged.
> What's left according to
[https://trac.torproject.org/projects/tor/wiki/org/teams/MetricsTeam/MetricsJavaStyleGuide
our style guide]:
>
> * changing file structure even more
> * adding a coverage task
> * adding a test task and
> * the first tiny test for verifying that test and coverage tasks work
Agreed.
> Should there be a `bin` directory added to the standard file structure
in order to have a place for scripts?
Well, we could move scripts to such a directory, but I could also see us
making those changes when we're changing the way ExoneraTor is executed.
Ideally, we'd do this via `sudo service exonerator start|stop|status|...`,
and that would include both the hourly updater and the (then Jetty-based)
servlet.
> I could take over the open topics in order to familiarize myself with
exonerator?
Please do!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19624#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs