[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18908 [Core Tor/Tor]: Implement monotonic time in a better way than simply calling down to libevent's non-monotonic time

#18908: Implement monotonic time in a better way than simply calling down to
libevent's non-monotonic time
----------------------------+------------------------------------
 Reporter:  nickm           |          Owner:  nickm
     Type:  enhancement     |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  review-group-5  |  Actual Points:  1
Parent ID:                  |         Points:  1
 Reviewer:  athena          |        Sponsor:
----------------------------+------------------------------------

Comment (by andrea):

 Begin code review for nickm/monotonic_v2:

 Summary: I think I'm good with this being merged as long as all four cases
 (clock_gettime(), gettimeofday(), Windows and Mac OS) got tested.

 aa971c59246332391116caafd18855bccf2f99a5:

  - Just moving code here.  Looks good to me.

 e42e054fbfb5dd8d4a5729f9f7988b2def60840e:

  - Good, this doesn't make any particular assumptions about the origin of
    monotonic time.  On current Linux, CLOCK_MONOTONIC is actually since
 system
    boot.  The parts for platforms I know look okay to me, but did we
 manage
    to actually test the Windows / Mac OS X stuff?

    (cf. e431ed37360a405f36e07a8c902146f0b4f4b31b)

 a2e5704a912ba06255c56de5603fce6444ebad98:

  - Looks fine.

 4baf1d04db6c8e84a113cc801284be3dbe23884e:

  - Looks okay.

 e431ed37360a405f36e07a8c902146f0b4f4b31b:

  - Hmm, looks okay but have we tested it on Windows yet?

 8edc842182df6c2036e51d5e4c3de6248f3065f9:

  - Just test suite exposure.

 1e21947464f81fb55e6f6ce52c43244933ef6657:

  - Okay, it compiles but have we tested it? :P

 cb45ee9494c93064ba61f6503aa9abfd583555db:

  - Woot, a pure code deletion commit

 81ca7a984a5a7820a5af5b9f1ad1f59d8c0ebc7f:

  - Looks fine.

 49ec146a3c7876c03040fefcab6345146d3b9ef3:

  - Unit tests only in this one; they look fine.

 8f0ba05a2522c56eebb8d239c5a3f431e88a7261:

  - Just the changes file

 End code review

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18908#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs