Re: [tor-bugs] #19613 [Metrics/Onionoo]: Onionoo should confirm to style guide

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#19613: Onionoo should confirm to style guide
-----------------------------+--------------------------------
 Reporter:  iwakeh           |          Owner:  karsten
     Type:  task             |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Onionoo 3.1.1
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #19611           |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 Great, the javadocs will be really useful when working on this code next.
 All checkstyle complaints gone.

 When upgrading to descriptor 1.3.0 the tests won't compile (the move to
 descriptor 1.3.0 is not part of the guide doc, but maybe good to do it
 now):
 {{{
 src/test/java/org/torproject/onionoo/updater/DummyConsensus.java:16:
 error: DummyConsensus is not abstract and does not override abstract
 method getSignatures() in RelayNetworkStatusConsensus
 }}}

 Open change is the file structure according to the
 [https://trac.torproject.org/projects/tor/wiki/org/teams/MetricsTeam/MetricsJavaStyleGuide#FileStructureofJavaProjects
 guide].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19613#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs