[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18902 [Core Tor/Tor]: Avoid variable shadowing in Tor



#18902: Avoid variable shadowing in Tor
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  easy, refactor, TorCoreTeam201607,   |        Version:
  review-group-5                                 |     Resolution:
Parent ID:  #19379                               |  Actual Points:  .3
 Reviewer:  teor                                 |         Points:  .3
                                                 |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------

Comment (by teor):

 In test_addr.c:
 {{{
 -      for (i=0;i<16;++i) {                                       \
 +      for (int ii_=0;i<16;++i) {                                 \
 }}}
 Should change all the i's to ii_'s.

 The rest looks ok.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18902#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs