[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22831 [Applications/Tor Browser]: Merge Snowflake for mac

#22831: Merge Snowflake for mac
---------------------------------------------+-----------------------------
 Reporter:  dcf                              |          Owner:  tbb-team
     Type:  task                             |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  snowflake TorBrowserTeam201707R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by dcf):

 * keywords:  snowflake => snowflake TorBrowserTeam201707R
 * status:  new => needs_review


Comment:

 See the [https://gitweb.torproject.org/user/dcf/tor-browser-
 bundle.git/log/?h=snowflake-
 mac-4&id=80b8e83b0d6ae349df4bcaeba34d6002e1bc7ea3 snowflake-mac-4] branch.

 It's split into four commits. Here is the overall diff:
 https://gitweb.torproject.org/user/dcf/tor-browser-bundle.git/diff/?h
 =snowflake-
 mac-4&id=80b8e83b0d6ae349df4bcaeba34d6002e1bc7ea3&id2=3f466124baf2718906e330b45388c22b2f1a44a7

 Here are points you may want to pay special attention to while reviewing
 (you may know better ways to do them):
  * [https://gitweb.torproject.org/user/dcf/tor-browser-
 bundle.git/tree/gitian/patches/webrtc-mac.patch?h=snowflake-
 mac-4&id=80b8e83b0d6ae349df4bcaeba34d6002e1bc7ea3#n42 webrtc-mac.patch
 embeds some CFLAGS] because I couldn't find another way to set them.
  * [https://gitweb.torproject.org/user/dcf/tor-browser-
 bundle.git/tree/gitian/patches/webrtc-mac.patch?h=snowflake-
 mac-4&id=80b8e83b0d6ae349df4bcaeba34d6002e1bc7ea3#n139 webrtc-mac.patch
 comments out a call to a function that is not available in the macOS 10.7
 SDK] that we are using. (I started a tbb-dev thread about the SDK version
 [https://lists.torproject.org/pipermail/tbb-dev/2017-July/000578.html
 here].)
  * [https://gitweb.torproject.org/user/dcf/tor-browser-
 bundle.git/tree/gitian/descriptors/mac/gitian-webrtc.yml?h=snowflake-
 mac-4&id=80b8e83b0d6ae349df4bcaeba34d6002e1bc7ea3#n69 Hack to hardcode SDK
 variables] and avoid the use of Xcode-only tools like xcrun.
  * [https://gitweb.torproject.org/user/dcf/tor-browser-
 bundle.git/tree/gitian/descriptors/mac/gitian-pluggable-transports.yml?h
 =snowflake-mac-4&id=80b8e83b0d6ae349df4bcaeba34d6002e1bc7ea3#n218 A sed
 command to overwrite randomly generated paths in snowflake-client.] I did
 a fair amount of searching and did not find an official way to remove
 these paths. The problem is being tracked upstream in
 [https://github.com/golang/go/issues/9206 GH#9206], which still has no
 solution. (Note that the upstream issue is about two things: embedded
 timestamps and variable build paths. We handle the timestamps with
 faketime and the variable build paths with sed.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22831#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs