[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17857 [Core Tor/Tor]: Create a consensus param to disable (netflow) padding if RSOS is enabled
#17857: Create a consensus param to disable (netflow) padding if RSOS is enabled
-------------------------------------------------+-------------------------
Reporter: teor | Owner:
| mikeperry
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, single-onion, review- | Actual Points:
group-20 |
Parent ID: | Points: 1
Reviewer: dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: merge_ready => needs_revision
* reviewer: => dgoulet
Comment:
Wait. I have a question here before we merge this.
Why is `channel_do_open_actions()` looking at the consensus param by
itself but yet we have a dedicated function that updates static value with
the param values `channelpadding_new_consensus_params()` and then we have
`channelpadding_decide_to_pad_channel()` that basically do the checks that
are done in `channel.c`.
Could `channel_do_open_actions()` just use that decide function which
would remove duplicated code and make channel ask the "padding subsystem"
directly instead of taking decision on its own?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17857#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs