[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21495 [Core Tor/Tor]: Fix scan-build warning: true and false branches are identical

#21495: Fix scan-build warning: true and false branches are identical
------------------------------+------------------------------------
 Reporter:  teor              |          Owner:  nickm
     Type:  defect            |         Status:  merge_ready
 Priority:  Very Low          |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor      |        Version:
 Severity:  Trivial           |     Resolution:
 Keywords:  clang scan-build  |  Actual Points:
Parent ID:                    |         Points:  0.1
 Reviewer:  dgoulet           |        Sponsor:
------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 If `n_found` is not 0 in that else condition, assert non fatal. Which
 means that anything above 1, we have a bug. Sounds good!

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21495#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs