[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17857 [Core Tor/Tor]: Create a consensus param to disable (netflow) padding if RSOS is enabled
#17857: Create a consensus param to disable (netflow) padding if RSOS is enabled
-------------------------------------------------+-------------------------
Reporter: teor | Owner:
| mikeperry
Type: enhancement | Status:
| needs_information
Priority: Medium | Milestone: Tor:
| 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, single-onion, review- | Actual Points:
group-20 |
Parent ID: | Points: 1
Reviewer: dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Comment (by dgoulet):
Thanks Mike/teor, I understand better the difference.
`channel_do_open_actions()` still has too much code regarding padding. It
has 4 if/else branches which 3 of them disable padding and one of them
reduces it but all of them look at torrc options *specific* to padding.
IMO, this is a "violation" of separation between subsystems and I'm no big
fan.
I would have like to see this big if/else in some sort of
"channelpadding_consider_on_open()" or sth which would not clobber
channel.c with padding stuff and then we can take care of code duplication
much easily afterwards. And afaict, that padding code in
`channel_do_open_actions()` is not tested by the unit test.
I understand the time constraint here, that "it is tested and any other
changes delay++" so I'm fine for now but my concerns will at least be on
the record ;).
Nick, it's your call now :).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17857#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs