[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

#22636: Add Travis configs so GitHub forks get CI coverage
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:
                                                 |  patrickod
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  continuous-integration ci testing    |  Actual Points:  .5
  best-practice unit-testing new-developers      |
  travis                                         |
Parent ID:                                       |         Points:  .5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Thanks!  This is very useful to have.  Technically this looks mostly good
 to me, with a few minor (mostly documentation) nits.

 I have a GitHub account with Travis CI enabled.  I confirm that tests on
 `bug22636_0.3.1` [https://travis-ci.org/tlyu/tor/builds/254404828 pass]
 and tests on `bug22636_0.2.4` [https://travis-
 ci.org/tlyu/tor/builds/254484617 pass].

 I'm trying to understand the differences between this and our Jenkins
 configurations.  It looks like our Jenkins config turns on `--disable-
 silent-rules` to get a bit more verbosity on the compile lines; should we
 do likewise?  Jenkins also does `make check` instead of `make check-
 spaces` and `make test`.  Is there some reason to not do `make check`?  I
 think that doesn't significantly increase the run time, but I haven't
 measured the difference yet.

 Commenting the `.travis.yml` with brief explanations of these choices
 might be a good idea.  Also, squashing the commits somewhat would be good.
 Some of the commit messages, like the ones involving Rust config choices,
 might work better as comments in `.travis.yml`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22636#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs