[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22831 [Applications/Tor Browser]: Merge Snowflake for mac

#22831: Merge Snowflake for mac
---------------------------------------------+--------------------------
 Reporter:  dcf                              |          Owner:  tbb-team
     Type:  task                             |         Status:  closed
 Priority:  Medium                           |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:  fixed
 Keywords:  snowflake TorBrowserTeam201707R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+--------------------------

Comment (by boklm):

 Replying to [comment:8 dcf]:
 >
 > Yes, it is probably a copy-paste error. The `GN_ARGS` in both
 descriptors are probably not minimal. The compile–test cycles are so long
 that I would try changing more than one thing at a time.

 Ah indeed, testing small changes like this takes a lot of time with
 gitian. The new build system in `tor-browser-build.git` should make that
 kind of changes easier to test as we can rebuild only what changed.

 >
 > If you find that the line is unnecessary, please remove it.

 I did not include this line when converting those changes to `tor-browser-
 build.git`, and it seems to work fine without it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22831#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs