[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header



#22895: Unused variables in donna's SSE2 header
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  027-backport, 028-backport,          |  Actual Points:
  029-backport, 030-backport, 031-backport,      |
  compile, warning, 32bit, ed25519, review-      |
  group-21                                       |
Parent ID:                                       |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Branch looks good to me. The variables removed are indeed unused.

 However, I wanted to compile the patch to check that it indeed fixes the
 gcc warnings. Can anyone help me compile tor in 32-bit mode? IIUC I should
 be doing `./configure --host=i686-linux-gnu "CFLAGS=-m32" && make`, but
 when I did that the configure script was complaining that it can't find my
 libevent. Is that the correct way to do it, and I just need to get a
 32-bit libevent or something? If someone helps me do this, I promise I'm
 gonna transcribe the process to `doc/HACKING/` for future generations to
 be able to do it as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22895#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs