[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13398 [Applications/Tor Browser]: at startup, browser gleans user FULL NAME (real name, given name) from O/S

#13398: at startup, browser gleans user FULL NAME (real name, given name) from O/S
--------------------------------------+---------------------------
 Reporter:  zinc                      |          Owner:  pospeselr
     Type:  defect                    |         Status:  accepted
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+---------------------------

Comment (by pospeselr):

 I've attached a patch addressing this issue as well as the modified
 'hello-world' add-on I used to manually verify the change (on Linux).
 Here's a description of the patch:

 Change Summary:

 - added new 'privacy.hide_user_info' setting which defaults to 'false' in
 firefox, but is set to 'true' in tor-browser via the 000-tor-browser.js
 script
 - added static bool sHideUserInfo bool to the nsUserInfo class
  - bool is inited and registered with the mozilla::Preferences system in
 static method nsUserInfo::InitializeStatics which is called from the
 nsAppStartup::Init method on firefox boot
 - refactored the various nsUserInfo objects such that the old platform
 specific Get$PROPERTY methods are now named Get$PROPERTYImpl
  - Single implementation of nsIUserInfo interface methods added to new
 nsUserInfo.cpp file
  - Each Get$PROPERTY method checks against newly added sHideUserInfo
 static bool before either returning an empty string, or calling the
 Get$PROPERTYImpl method
  - Now calling the new Get$PROPERTYImp methods where appropriate (in the
 UNIX implementation of GetEmailAddress for instance)
 - refactor to OSX nsUserInfo implementation
  - changed GetPrimaryEmailAddress to be static function in
 nsUserInfoMac.mm, rather than a 'secret' class method (since it is not
 dependent on any object specific data or private/protected methods)
  - removed the OSX specific nsUserInfoMac.h header which included the
 'secret' GetPrimaryEmailAddress method

 Caveats:

 - haven't verified this change works (or even builds) on Windows or OSX
  - seems like something is borked with my Linux install regarding
 virtualization, so I'm going to wipe and re-install fresh
  - will resend an updated patch if I get to that this weekend and find any
 build or runtime errors on these platforms
 - an automated test also needs to be added verifying this parameter works
 as intended, if I have time this weekend will try to get that going too

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13398#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs