[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22895 [Core Tor/Tor]: Unused variables in donna's SSE2 header

#22895: Unused variables in donna's SSE2 header
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  027-backport, 028-backport,          |  Actual Points:
  029-backport, 030-backport, 031-backport,      |
  compile, warning, 32bit, ed25519, review-      |
  group-21                                       |
Parent ID:                                       |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Thanks for the help Nick. I managed to compile Tor in 32-bit mode:

 {{{
 $ file src/or/tor
 src/or/tor: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV),
 dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 2.6.32,
 BuildID[sha1]=72f975f78f2ef98852368ebbe3a6205ddf0ea944, not stripped
 }}}

 I still have not managed to trigger this error unfortunately, even tho I
 compiled tor with `$ CFLAGS="-m32" ./configure --enable-gcc-warnings
 --disable-asciidoc --enable-expensive-hardening` and I checked that
 `src/ext/ed25519/donna/libed25519_donna.a` was built...

 Not sure what to do here. Anyone has tips on how to repro this?

 Otherwise, I just say we merge the patch since it just removes unused
 variables anyway (I checked all of them).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22895#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs