[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #23056 [Core Tor/Tor]: prop224: Intro point aren't transfered between services on HUP
#23056: prop224: Intro point aren't transfered between services on HUP
------------------------------+--------------------------------
Reporter: dgoulet | Owner: dgoulet
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Keywords: prop224, tor-hs
Actual Points: | Parent ID:
Points: 0.1 | Reviewer:
Sponsor: |
------------------------------+--------------------------------
For the current prop224 upstream code, the `move_intro_points()` function
doesn't work as expected, actually it's very broken.
First of all, it is impossible to move intro points with the current
condition because the newly created service (`dst`) doesn't have any
descriptor. Thus, this if() is basically dead code and we never move intro
points.
{{{
if (src->desc_current && dst->desc_current) {
move_descriptor_intro_points(src->desc_current, dst->desc_current);
...
}}}
The fix is to move the *descriptor(s)* and not only the intro points
because the service needs the descriptor signing key that cross certify
every IP authentication key. So, we really need to move the full thing
from one service to the other else we would have to re-sign everything.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23056>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs