[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26497 [Core Tor/Tor]: set CARGO_HOME correctly or stop using it
#26497: set CARGO_HOME correctly or stop using it
--------------------------+------------------------------------
Reporter: catalyst | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust, tor-ci | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by catalyst):
Replying to [ticket:26497 catalyst]:
> The setting of `CARGO_HOME` is redundant if we `cd` to the correct
directory first. Or we could stop changing directories and instead set
`CARGO_HOME` correctly. We probably shouldn't do both because it's
confusing and possibly inconsistent.
These are the reasons I can think of to set `CARGO_HOME` during our build:
* so cargo finds the correct `.cargo/config` file; this can be worked
around by doing a `cd` to the correct directory
* so cargo uses the desired cache directory for online crates if we're
configured with `--enable-cargo-online-mode`; we might not actually want
to do this (see #26038)
* are there other reasons I'm missing here?
I looked briefly at the source code of cargo and it seems to be consistent
with the above.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26497#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs