[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24296 [Metrics/Onionoo]: Make Onionoo's document classes available as part of metrics-lib



#24296: Make Onionoo's document classes available as part of metrics-lib
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:6 karsten]:
 > Mote that I spent quite some time on the `ZonedDateTime` change
 mentioned above. Maybe we'll have to do that after moving things over to
 metrics-lib.

 s/Mote/Note/

 Sometimes it helps to sleep over something. I guess my mistake was that I
 wanted to change attribute types from `String` to `ZonedDateTime`, and
 that turned out to be more difficult with Jenkins than I had expected.
 What we could do, though, is leave attributes as `String` types and simply
 provide additional getters and setters that work with `ZonedDateTime`
 representations of those `String` values. I might try that out later
 today, though not now.

 Leaving in needs_review for the first commit that is unrelated to dates.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24296#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs