[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3569 [Core Tor/Tor]: Refactor socks parsing

#3569: Refactor socks parsing
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  rl1987
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, intro, trunnel,          |  Actual Points:
  prop229, refactor, code-quality, 035-triaged-  |
  in-20180711                                    |
Parent ID:                                       |         Points:  4
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 Okay, I've been over all the changes and looked at the comments.  I
 squashed the branch, and then merged it forward, and then added a fuzzer
 for it.  While fuzzing, I found one memory leak, and squashed it.  I think
 I like this branch now.

 Please have a look at branch `socks_trunnel4_squashed_merged` in my public
 repository, and let me know if you like it too?  I've given it a PR at
 https://github.com/torproject/tor/pull/229

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3569#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs