[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
-----------------------------------------------+---------------------------
 Reporter:  sysrqb                             |          Owner:  tbb-team
     Type:  task                               |         Status:
                                               |  needs_review
 Priority:  Very High                          |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531                             |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by sysrqb):

 Replying to [comment:8 igt0]:
 > ''21f0480aff98 Bug 25741 - TBA: Only include Firefox Account permissions
 if we want them''
 > **LGTM**
 >

 After the next round of reviews, I'll fixup this commit so it includes:
 {{{
 diff --git a/mobile/android/base/FennecManifest_permissions.xml.in
 b/mobile/android/base/FennecManifest_permissions.xml.in
 index 590429845085..1b7b2d5475ec 100644
 --- a/mobile/android/base/FennecManifest_permissions.xml.in
 +++ b/mobile/android/base/FennecManifest_permissions.xml.in
 @@ -30,7 +30,9 @@
      <uses-permission
 android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
      <uses-permission
 android:name="com.android.launcher.permission.INSTALL_SHORTCUT"/>
      <uses-permission
 android:name="com.android.launcher.permission.UNINSTALL_SHORTCUT"/>
 +#ifdef MOZ_ANDROID_LOCATION
      <uses-permission
 android:name="com.android.browser.permission.READ_HISTORY_BOOKMARKS"/>
 +#endif

      <uses-permission android:name="android.permission.WAKE_LOCK"/>
      <uses-permission android:name="android.permission.VIBRATE"/>
 }}}

 (based on the comment I made at the bottom of ticket:24796#comment:10)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs