[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24296 [Metrics/Onionoo]: Make Onionoo's document classes available as part of metrics-lib



#24296: Make Onionoo's document classes available as part of metrics-lib
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Oh, well. Even though the `ZonedDateTime` change doesn't look terribly
 hard, I'm still running into issues. I feel like this is a perfect-is-the-
 enemy-of-good case. How about we postpone the `ZonedDateTime` change and
 go with the Jackson-related changes only for now? In particular, would you
 like to review
 [https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-24296&id=403f107954c3a35e8b444e401e650d8d10b8f396
 commit 403f107 in my task-24296 branch] that adds annotations as discussed
 above? We can still make more changes later. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24296#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs