[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25669 [Core Tor/Tor]: Privcount: blinding and encryption should be finished up
#25669: Privcount: blinding and encryption should be finished up
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: privcount, 035-roadmap-master, 035 | Actual Points:
-triaged-in-20180711, rust |
Parent ID: #22898 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:11 chelseakomlo]:
> I glanced over this with an eye towards the Rust conventions we've been
working towards in tor- would it be helpful to do a Rust style/format
review now, or wait for some of these other fixes first?
I don't think there are any major changes left, so I think we would
benefit from a rust style review at this point.
To solve i128 miscompilation, we should disable i128 for:
* rust stable versions 1.25 and earlier, which don't support i128, and
* rust platforms where the unit tests fail because i128 is miscompiled.
(We do the same thing for optimised C code which doesn't work on some
platforms.)
I'll look up the rust incantations to define a feature (tor_enable_i128)
and submit a patch, hopefully later this week.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25669#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs