[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
--------------------------------------------+------------------------------
Reporter: cypherpunks | Owner: tbb-team
Type: defect | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff60-esr, TorBrowserTeam201807 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------------+------------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Replying to [comment:15 sukhbir]:
> For review:
>
> https://github.com/azadi/tor-browser-build-1/tree/bug-25485
>
> This is tested on Ubuntu 17.04 (`gcc 7`; newer) as well as Ubuntu 16.04
(`gcc 5.3.1`; older). To initiate the ABI check, we compare the installed
`gcc` version with the bundled Tor Browser version `6.4.0`. If the
installed version is more recent, we remove the bundled `libstdc++.so.6`
from `Browser/TorBrowser/Tor`, which removes it from `LD_LIBRARY_PATH`.
That makes me nervous. It is not unusual (at least for me) to have
different compiler versions around on my Linux box and use them. If I
happen to use a newer version than usual your patch my blow away my
libstdc++ which Tor Browser ships but switching back to my regular
compiler suddenly breaks Tor Browser now.
I think trying to figure out the installed libstdc++ version and comparing
it to the one we ship and not using the latter if the former is newer
seems like a more plausible idea to me. However, there might be pitfalls
we'd like to avoid in this scenario as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25485#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs