[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26815 [Core Tor/Tor]: Use NSS for our symmetric crypto, digests, and PRNG.
#26815: Use NSS for our symmetric crypto, digests, and PRNG.
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 035-roadmap-subticket, 035-triaged- | Actual Points:
in-20180711 |
Parent ID: #26631 | Points:
Reviewer: catalyst | Sponsor:
| Sponsor8-can
-------------------------------------------------+-------------------------
Changes (by catalyst):
* status: needs_review => needs_revision
Comment:
Thanks for working on this! At first glance it seems reasonable. I'm
still looking at the diffs more carefully.
I did notice that github is saying it can't auto-merge, so some rebasing
might be needed. Also, when building the (unmerged) branch on Ubuntu
16.04.4 amd64 with libnss3-dev 2:3.28.4-0ubuntu0.16.04.3, I get this
warning:
{{{
In file included from ../src/lib/crypt_ops/crypto_nss_mgt.c:20:0:
/usr/include/nss/ssl.h:397:1: warning: function declaration isn’t a
prototype [-Wstrict-prototypes]
SSL_IMPORT unsigned int SSL_SignatureMaxCount();
^
}}}
This halts the build if configured with `--enable-fatal-warnings`. I
don't know if this is a known bug in the headers, or if it's because of
something else we did.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26815#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs