Re: [tor-bugs] #28672 [Circumvention/Snowflake]: Android reproducible build of Snowflake

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28672: Android reproducible build of Snowflake
-------------------------------------------------+-------------------------
 Reporter:  dcf                                  |          Owner:  (none)
     Type:  project                              |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Circumvention/Snowflake              |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  GeorgKoppen201904, ex-sponsor-19,              |
  TorBrowserTeam201907                           |
Parent ID:  #30318                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor28-can
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:25 boklm]:
 > Replying to [comment:24 gk]:
 > > 3) What's the reason for moving the `gclient config` part outside of
 the `if [ ! -d "src"]` one, in particular as this affects non-Android
 platforms as well. And what does it mean? That it is
 > > not run for Linux and macOS anymore?
 >
 > If the `gclient config` is behind the `if [ ! -d "src"]`, then changes
 to gclient config are not taken into account unless we remove the `src`
 directory. So moving it outside allows us to update this config without
 removing the `src` directory.
 >
 > It seems we should have a patch moving that part outside of the `if [ !
 -d "src"]` on the stable branch too, otherwise building master will update
 the gclient config, and then building stable will keep using the master
 version of the gclient config.

 Okay, sounds reasonable. Yes, we should keep that in mind once we need
 this on stable (which we currently don't do).

 > The `target_os` line means fetching dependencies specific for those
 platforms. It seems we don't need specific dependencies for the Linux and
 macOS builds as we had no `target_os` defined before.
 >
 > With this change we will fetch Android dependencies (and Windows ones,
 but we can remove it for now), and will include it in the webrtc tarball
 used for every platforms. This means we include some dependencies not
 needed in the Linux and macOS builds, but this avoids generating one
 tarball for each platform.

 Yes, that seemed to be perfectly reasonable. Just the Windows part is not
 needed yet (maybe not even ever given the build issues), thus let's remove
 it for now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28672#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs