[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30237 [Applications/Tor Browser]: Tor Browser: Improve TBB UI of hidden service client authorization
#30237: Tor Browser: Improve TBB UI of hidden service client authorization
--------------------------------------+--------------------------------
Reporter: asn | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201906 | Actual Points:
Parent ID: #30000 | Points:
Reviewer: | Sponsor: Sponsor27-must
--------------------------------------+--------------------------------
Comment (by antonela):
Thanks mcs and brade, it looks great! Will go inline:
> * Our tor-browser changes do not support localization (see the many
places that are marked with L10n). Kathy and I would like to understand
our localization strategy in a post-Torbutton world before we work on L10n
support.
> * We need to insert the correct "Learn More" URL.
Yes. I can coordinate it with the community team. The link should give
users more info about why they need a key and how they can find it. Filed
#31069 to make it happen.
> * The text/copy will need some work. Some concepts are difficult to
communicate clearly. For example, if the user enters a key of the wrong
length or format, we currently show the somewhat cryptic validation error
that is visible in the screenshot I posted.
I was able to reproduce two kinds of errors: "Please enter a valid key"
and "Unable to configure Tor with your key". Are more errors coming?
Could we use a class to make those errors look more like an error? We can
rely on the firefox suggestions ->
https://design.firefox.com/photon/patterns/errors.html
> * We need artwork for the onion icon that is used within the prompt (and
if it would be better to do so, we could remove it). As a placeholder, we
are using a plain onion image that we downloaded from
https://media.torproject.org/image/Onion%20Icon/
I think we can use Firefox's login/key icon. Do we want a custom icon
here?
https://design.firefox.com/icons/icons/desktop/login-16.svg
> * We would like Antonela to give us feedback about the UX flow and
overall experience. For example, while the prompt is displayed we show a
blank page behind it. Is that okay?
>
I think the white page is good for now, I'll think more about it. We
should have a better error page when users click "Cancel". I'll make sure
we have it in consideration for #30025.
> Using the above patches, we created some builds for testing. We used a
tor daemon based on David's ticket30381_042_01 branch from
https://git.torproject.org/user/dgoulet/tor.git (which includes the work-
in-progress patches for both #30381 and #30382). Please look at the
README.txt file that is in the same directory as the builds for a helpful
tip about reducing your `SocksTimeout` setting.
Thanks a lot for doing this!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30237#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs