[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30934 [Circumvention/Snowflake]: Add a "Turn Off/On" toggle
#30934: Add a "Turn Off/On" toggle
-------------------------------------+-----------------------------
Reporter: arlolra | Owner: cohosh
Type: defect | Status: merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: snowflake-webextension | Actual Points:
Parent ID: | Points:
Reviewer: arlolra | Sponsor:
-------------------------------------+-----------------------------
Comment (by cohosh):
Replying to [comment:21 cohosh]:
> Replying to [comment:19 dcf]:
> > Replying to [comment:17 cohosh]:
> > > Hrm I'm seeing what looks like an infinite loop that the extension
eventually goes into.
> >
> > Could it be if `broker.getClientOffer` (first HTTP request to broker)
succeeds, but then ProxyPair.receiveOffer fails (JSON parsing and second
HTTP request to broker). In that case, the ProxyPair is neither closed nor
set inactive? Formerly, the ProxyPair was only set `active` after
receiving the client offer, compared to now where it is set `active`
immediately and made inactive when there's an error. Forgive me, I might
be misinterpreting the code.
> Yeah that's what I'm looking into, I'll add a fix to cover that case but
it actually seems that the WebRTC might not be closing correctly. My
snowflake has been green (active) for well over an hour now. Usually the
connection times out during a browsing session before then.
[https://github.com/cohosh/snowflake/commit/501c26b64d320a3e173a80f68eb256012ddc968d
This commit] should put us back at the state we were at before the
refactor in terms of error checking and returning the pair to inactive.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30934#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs