[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27503 [Applications/Tor Browser]: Disabling accessibility on Windows breaks screen readers

#27503: Disabling accessibility on Windows breaks screen readers
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  GeorgKoppen201903, tbb-8.5,                    |
  TorBrowserTeam201907R                          |
Parent ID:                                       |         Points:
 Reviewer:  boklm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by pospeselr):

 Ok here's everything  you should need to review gk:

 **wine**: https://github.com/pospeselr/wine/commits/winedev2

 This wine branch is my review dev branch as of yesterday. I have one more
 piece of feedback to work on (commit
 `8baf184001c6bcdc3ec1867c6bb6fa82b5ffed15` ) before it's again submitted
 for review. I'm be switching over to a new winedev3 branch to make sure
 everything stays lined up on our end.

 **mingw-w64**: https://github.com/pospeselr/mingw-w64/commits/bug_27503

 This branch has two commits on top of commit
 `2d4e517ad0c7a9f0bd7001c42e6c131b977c15d9` used in tor-browser-build.

 The first is a copy of widl's .c, .h, .l and .y files from the last commit
 in my winedev2 wine branch (commit
 `0922d3d66976f7185ea81b797fa1081e097e71f8` ). Note this does include the
 sources generated from parser.y and parser.l as the mingw build system
 does not include widl's yacc and bison step and just has their outputs
 checked into the mingw source tree.

 The second applies the mingw `0001-relocatable.patch` which adds extra
 logic for finding mingw's header directories .
 **
 tor-browser-build**: https://gitweb.torproject.org/user/richard/tor-
 browser-build.git/commit/?h=bug_27503

 This change adds a patch step to the mingw-w64 project. The included
 `27503.patch` can be generated from the above mingw-w64 branch via `git
 diff bug_27503~2`

 ----

 I believe that covers everything. I'm doing a few test nightly builds with
 the latest tor-browser-build patch set to verify things still work.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27503#comment:92>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs