[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30468 [Applications/Tor Browser]: Ship macedonian Tor Browser in alpha series
#30468: Ship macedonian Tor Browser in alpha series
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: localization, | Actual Points:
TorBrowserTeam201907R, GeorgKoppen201907 |
Parent ID: #29935 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by boklm):
Replying to [comment:12 gk]:
> Alright, here come patches in three of my user repos up for review:
>
> 1) `torbutton`: `bug_30468_v4`
(https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_30468_v4)
This looks good to me.
> 2) `tor-launcher`: `bug_30468_v2` (https://gitweb.torproject.org/user/gk
/tor-
launcher.git/commit/?h=bug_30468_v2&id=397253580d87f74447fe150f7336edcf4d816c79)
This looks good to me.
> 3) `tor-browser-build`: `bug_30468_v2
(https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_30468_v2&id=27cd99e5978b3fe9db53ebecec5b97a3cd809c28)
(thanks to boklm for the help here!)
This looks good to me. Although I misunderstood when talked about it on
IRC, and was thinking that mk was for android only (instead of desktop
only). Here is an alternative version of the patch that is a little more
simple, skipping mk on android:
https://gitweb.torproject.org/user/boklm/tor-browser-
build.git/commit/?h=bug_30468&id=7b1c46d3649c20c91d4e33529412301e96ce2a0f
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30468#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs