[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30933 [Circumvention/Snowflake]: Get rid of CoffeeScript from the JS proxy

#30933: Get rid of CoffeeScript from the JS proxy
-------------------------------------+-----------------------------------
 Reporter:  arlolra                  |          Owner:  arlolra
     Type:  defect                   |         Status:  needs_information
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  dcf                      |        Sponsor:
-------------------------------------+-----------------------------------
Changes (by dcf):

 * status:  needs_review => needs_information


Comment:

 Great job on this. You covered some details that I would have missed. I
 looked at
 [https://github.com/keroserene/snowflake/commits/4b97c9d524268f5e1242d0e9b537a4dc6486c01f
 4b97c9d524268f5e1242d0e9b537a4dc6486c01f]. Just a couple of questions.

 1.
 [https://github.com/keroserene/snowflake/commit/b5934883d45a322dd45f2b7467798ec48b5552e1
 b5934883d4] "Don't overwrite global location": The commit also adds checks
 for `snowflake !== null`. Are those related to the `location` change, or
 could they be split out?
 2.
 [https://github.com/keroserene/snowflake/commit/d1af00da676094a6842501f87faf2367f679cf02
 d1af00da67] "Don't specify port for stun server": How was this working
 before? Was there a hardcoded default inside libwebrtc?

 I did the CoffeeScript rebuild step myself starting from
 [https://github.com/keroserene/snowflake/commit/7f5cd81f94c530d0142f7caec90581d56a65bafb
 60fe1ae18b^] and got the same output as your
 [https://github.com/keroserene/snowflake/commit/60fe1ae18b7a1a76a180f6334faa306a64265277
 60fe1ae18b].

 In order to download the newer version of CoffeeScript needed, I had to
 modify package.json. It might be worth sneaking in a commit to this
 effect, as documentation in the log.
 {{{#!diff
 -    "coffee-script": "^1.12.2",
 +    "coffeescript": "^2",
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30933#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs