[tor-bugs] #1574 [EFF-HTTPS Everywhere]: Apparently we break Request Policy

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1574: Apparently we break Request Policy
----------------------------------+-----------------------------------------
 Reporter:  pde                   |       Owner:  pde
     Type:  defect                |      Status:  new
 Priority:  major                 |   Milestone:     
Component:  EFF-HTTPS Everywhere  |     Version:     
 Keywords:                        |      Parent:     
----------------------------------+-----------------------------------------
 From Justin Samuel:

 Thanks for making HTTPS Everywhere. It would be great if it could be
 compatible with extensions that needs to know when URIs get rewritten.

 For example, my extension (RequestPolicy) currently has no way of
 knowing that rewritten requests from link clicks should be allowed. As a
 result, things like clicking on wikipedia links in google results fail,
 which is a bummer. (As a warning in case you decide to test this
 particular example: they do work on the second click because HTTPS
 Everywhere changes the request context's src when rewriting).

 Attached is a patch for HTTPS Everywhere that sends observer service
 notifications for URI rewrites. Let me know if there's anything I an
 do to help get this patch or an equivalent added. Note that the most
 reliable and simplest place I could see to add the notification was in
 RuleSet.prototype.replaceURI(). If you have better suggestions, let me
 know. Extra notifications are preferable to missed or after-the-fact
 notifications.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1574>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online