[tor-bugs] Re: #1209 [Tor - Tor client]: crypto.c:322 _crypto_new_pk_env_rsa: Assertion rsa failed; aborting.

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1209: crypto.c:322 _crypto_new_pk_env_rsa: Assertion rsa failed; aborting.
---------------------------+------------------------------------------------
 Reporter:  Safari         |         Type:  defect          
   Status:  closed         |     Priority:  minor           
Milestone:                 |    Component:  Tor - Tor client
  Version:  0.2.2.6-alpha  |   Resolution:  worksforme      
 Keywords:                 |       Parent:                  
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  new => closed
  * resolution:  None => worksforme


Comment:

 So there are only a few call-sites for _crypto_new_pk_env_rsa().  The only
 one right now that doesn't check for a NULL value of the argument before
 calling it is crypto_pk_copy_full().   This was also true in Tor
 0.2.2.6-alpha, where the bug occurred.

 I've updated the crypto_pk_copy_full function (as of git commit 8e1bf98)
 so that if copying the key fails, it will log any errors that openssl
 generates.  Unfortunately, the key-copying logic in openssl uses the ASN1
 machinery so heavily that I'm really not able to look at changes between
 openssl 20091229 and now to see if any of them might have been
 responsible.

 Closing this bug as 'worksforme' for now since it hasn't come back; please
 let us know  if it ever comes back, especially if you can get the message
 generated by the next Tor version.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1209#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online