[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3370 [Tor Client]: Race condition - file system access in Tor

#3370: Race condition - file system access in Tor
------------------------+---------------------------------------------------
 Reporter:  runa        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: unspecified  
Component:  Tor Client  |        Version:  Tor: 0.2.2.27-beta
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * milestone:  => Tor: unspecified


Comment:

 We should fix the part of these that we can for cleanliness.  Most of the
 "if file_status()==FN_FILE then read_file_to_string" checks are silly:
 they could just be read_file_to_string with an appropriate response to
 errors.

 In fact, most file_status() checks should be considered suspect.
 Generally, instead of "may I do X with this file" then trying it, we
 should just try to do X and see if we get an error.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3370#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs