[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3376 [Tor Relay]: [PATCH] Avoid a NULL dereference in node nickname comparison.

#3376: [PATCH] Avoid a NULL dereference in node nickname comparison.
-----------------------+----------------------------------------------------
 Reporter:  meyering   |          Owner:     
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:     
Component:  Tor Relay  |        Version:     
 Keywords:             |         Parent:     
   Points:             |   Actualpoints:     
-----------------------+----------------------------------------------------

Comment(by nickm):

 >Hrm, where is the result actually dereferenced? I don't see it currently.

 The value n is passed as "nickname" to hex_digest_nickname_matches(),
 where it can be passed to strcasecmp.

 I think that this fix is incorrect.  Assuming it becomes possible to have
 a node_t without a nickname, we would still want it to match "$identity".
 So I believe the right fix is instead to change
 hex_digest_nickname_matches so that it tolerates nickname==NULL correctly.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3376#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs