[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2411 [Tor Client]: expand getinfo circuit-status to show build_state flags

#2411: expand getinfo circuit-status to show build_state flags
-------------------------+--------------------------------------------------
 Reporter:  arma         |          Owner:  rransom           
     Type:  enhancement  |         Status:  needs_review      
 Priority:  major        |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:  #2114             
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by rransom):

 Replying to [comment:11 nickm]:
 > Noting here so that it doesn't get lost:
 >
 > The patch looks good.  Before we merge it, though, there's a problem
 with controllers: at least pytorctl has the problem that if we insert new
 fields in CIRC events *before* the reason fields, it won't understand
 REASON fields any more.
 >
 > Our  options are:
 >
  * Fix pytorctl, give everybody plenty time to upgrade, then merge this.
  * Change this patch so that the new CIRC fields come last, then merge it.
 In parallel, fix pytorctl so we don't have to do this nonsense in the
 future.
 >
 > I favor the second; rransom (I believe) favors the first.

 Some of the reasons I don't want to change this patch are:

  * Rearranging the code to put event-specific flags for `FAILED` and
 `CLOSED` events in the middle of the keywords describing a circuit's
 current state would significantly uglify Tor's code.
  * The `PURPOSE` event extension was added after the `REASON` and
 `REMOTE_REASON` fields were, so the spec has previously been interpreted
 as allowing new event extensions to be placed anywhere after the non-
 extended event.  PyTorCtl is thus quite broken.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2411#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs