[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3443 [Tor Client]: Client with low CBT can't establish any circuits
#3443: Client with low CBT can't establish any circuits
------------------------+---------------------------------------------------
Reporter: arma | Owner:
Type: defect | Status: new
Priority: major | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: regression | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by nickm):
Replying to [comment:25 mikeperry]:
> Replying to [comment:24 nickm]:
> > I'm not a fan of changing what "timestamp_created" means if there is
anything else that uses it; I'd rather introduce a new timestamp with the
right semantics and set/look at that instead.
>
> I dunno.. That also seems odd to me. If you insist, we could add a
'timestamp_began' at the point/points where CREATE and CREATE_FAST get
sent, but then I think we're going to find that we will have no instances
of timestamp_created left in use in that case, as everything should then
switch to using timestamp_began. I think circuit timeout and build time
measurement should all behave uniformly, and not sometimes have TLS
connection setup overhead factored in, and sometimes not.
If that's the case, we should rename the field. "created" doesn't mean
"was able to sent its first create cell".
Looks like the field is used in control.c, in rephist.c, and in circ*.c.
A fair bit to audit; probably not totally impossible.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3443#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs