[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5589 [Tor Bridge]: validate_pluggable_transports_config() is not called after SIGHUP

#5589: validate_pluggable_transports_config() is not called after SIGHUP
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:  pt          |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by asn):

  * status:  new => needs_review


Comment:

 Please see `bug5589` in `https://git.gitorious.org/mytor/mytor.git`.

 I've heard that fixing bugs by removing code is a good thing, and this is
 such a fix.

 I've removed `validate_pluggable_transports_config()` and now rely on
 `connection_or_connect()` to issue the warning. Since tor will call
 `connection_or_connect()` when it tries to get the descriptor of a bridge,
 or when it tries to build a circuit through it, I think that the warning
 will be issued in all relevant cases.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5589#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs