[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2385 [Tor Hidden Services]: rendservice.c: cleanup stack stored key material

#2385: rendservice.c: cleanup stack stored key material
-----------------------------------+----------------------------------------
    Reporter:  cypherpunks         |        Type:  defect             
      Status:  needs_review        |    Priority:  normal             
   Milestone:  Tor: 0.2.3.x-final  |   Component:  Tor Hidden Services
     Version:                      |    Keywords:  audit              
      Parent:                      |      Points:                     
Actualpoints:                      |  
-----------------------------------+----------------------------------------

Comment(by nickm):

 Looks good!  Notes to myself:

  * In rend_service_load_keys in 9f55dfd91561643, I think the duplicated
 free code is somewhat worrisome. I should check whether there's a reason
 not to use the goto err/goto done pattern there.
  * Same function, ab2e007ffbb6a6c, there are some internal spaces between
 the parens in the "if ( ... )" and the tested thing.
  * In the changes file, a changelog entry that says it's a bugfix is
 supposed to say what the bug number was and version the bug appeared in.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2385#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs